ci: skip CI jobs when unaffected by changed paths by mishushakov · Pull Request #1380 · e2b-dev/E2B

mishushakov · 2026-06-02T13:02:42Z

Adds a dorny/paths-filter change-detection job to the PR-triggered workflows so jobs only run when relevant paths change: Lint/Typecheck run only when package code, spec, or lint configs change; Generated files runs only when codegen inputs/outputs change; and the JS/Python/CLI SDK tests run only when the respective SDK changes (CLI also runs on JS SDK changes since it builds against it). The SDK test jobs are gated inside the reusable workflows via a new run input rather than by skipping the caller, so the required matrix status checks still report (skipped jobs report success) and branch protection stays satisfied. Shared paths (spec, lockfiles, package.json, .tool-versions) and workflow_dispatch runs still trigger everything.

🤖 Generated with Claude Code

Add a dorny/paths-filter "changes" detection job to the PR-triggered workflows so jobs only run when relevant paths change: - Lint / Typecheck: only when package code, spec, or lint configs change - Generated files: only when codegen inputs/outputs change - JS / Python / CLI SDK tests: only when the respective SDK changes (CLI also runs when the JS SDK changes, since it builds against it) The SDK test jobs are gated inside the reusable workflows via a new `run` input so the required matrix status checks still report (skipped jobs report success), keeping branch protection satisfied. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

cursor · 2026-06-02T13:02:51Z

PR Summary

Medium Risk
Wrong path filters could skip tests that should run; the run-input skip pattern assumes GitHub treats skipped matrix jobs as passing required checks.

Overview
PR workflows now use dorny/paths-filter so lint, typecheck, generated-files, and SDK test orchestration only run when matching paths change. Reusable JS, Python, and CLI test workflows take a run input and gate the matrix with if inputs.run so callers still invoke the workflow and required checks can succeed when tests are skipped. sdk_tests.yml maps js, python, and cli filters (CLI includes js-sdk), runs the filter step only on pull_request, and forces a full run on workflow_dispatch.

^{Reviewed by Cursor Bugbot for commit 7655d17. Bugbot is set up for automated code reviews on this repo. Configure here.}

changeset-bot · 2026-06-02T13:02:58Z

⚠️ No Changeset found

Latest commit: 7655d17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-06-02T13:03:51Z

Package Artifacts

Built from 38f1d83. Download artifacts from this workflow run.

JS SDK (e2b@2.30.1-mishushakov-conditional-ci-jobs.0):

npm install ./e2b-2.30.1-mishushakov-conditional-ci-jobs.0.tgz

CLI (@e2b/cli@2.11.2-mishushakov-conditional-ci-jobs.0):

npm install ./e2b-cli-2.11.2-mishushakov-conditional-ci-jobs.0.tgz

Python SDK (e2b==2.29.0+mishushakov-conditional-ci-jobs):

pip install ./e2b-2.29.0+mishushakov.conditional.ci.jobs-py3-none-any.whl

dorny/paths-filter falls back to git commands on non-PR events, which fails without a checkout. Guard the filter step to pull_request only; the run inputs already force a full run on workflow_dispatch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68854cbb35

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Enumerating individual generated outputs was fragile and missed the Python volume/mcp codegen targets. Generated files are interleaved with hand-written code inside the SDK source trees, so watch the whole trees to catch drift without maintaining a per-file allowlist. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Simpler and fully robust: any package change re-verifies generated code is in sync, with no per-path allowlist to maintain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The codegen toolchain versions are pinned via the lockfile/package.json and .tool-versions, so a dependency-only PR can change generated output. Watch the same shared paths as the lint/typecheck/sdk-tests filters. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

matthewlouisbrockman

i like it! if we start seeing weird issues from missing issues on loosely related code can revisit but hopefully makes faster

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7655d17. Configure here.}

cla-bot Bot added the cla-signed label Jun 2, 2026

cursor Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread .github/workflows/sdk_tests.yml

mishushakov and others added 2 commits June 2, 2026 15:36

Merge branch 'main' into mishushakov/conditional-ci-jobs

68854cb

mishushakov marked this pull request as ready for review June 2, 2026 14:52

mishushakov requested review from ValentaTomas and jakubno as code owners June 2, 2026 14:52

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread .github/workflows/generated_files.yml Outdated

cursor Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread .github/workflows/sdk_tests.yml

claude Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread .github/workflows/generated_files.yml Outdated

mishushakov and others added 2 commits June 2, 2026 18:22

ci: run generated-files check on any packages/ change

530b52d

Simpler and fully robust: any package change re-verifies generated code is in sync, with no per-path allowlist to maintain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

cursor Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread .github/workflows/generated_files.yml

mishushakov enabled auto-merge (squash) June 4, 2026 13:59

mishushakov added 2 commits June 4, 2026 15:59

Merge branch 'main' into mishushakov/conditional-ci-jobs

e430fc8

Merge branch 'main' into mishushakov/conditional-ci-jobs

585fb81

mishushakov assigned matthewlouisbrockman Jun 15, 2026

mishushakov requested a review from matthewlouisbrockman June 15, 2026 14:03

mishushakov unassigned matthewlouisbrockman Jun 15, 2026

matthewlouisbrockman approved these changes Jun 15, 2026

View reviewed changes

Merge branch 'main' into mishushakov/conditional-ci-jobs

7655d17

cursor Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread .github/workflows/js_sdk_tests.yml

mishushakov merged commit 1d6c45c into main Jun 15, 2026
29 checks passed

mishushakov deleted the mishushakov/conditional-ci-jobs branch June 15, 2026 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: skip CI jobs when unaffected by changed paths#1380

ci: skip CI jobs when unaffected by changed paths#1380
mishushakov merged 9 commits into
mainfrom
mishushakov/conditional-ci-jobs

mishushakov commented Jun 2, 2026

Uh oh!

cursor Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthewlouisbrockman left a comment

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mishushakov commented Jun 2, 2026

Uh oh!

cursor Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

changeset-bot Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Artifacts

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthewlouisbrockman left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor Bot commented Jun 2, 2026 •

edited

Loading

changeset-bot Bot commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading